Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #10

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Update README.md #10

merged 1 commit into from
Sep 30, 2023

Conversation

lmalenfant
Copy link
Member

I added the SonarCloud status to the ReadMe here also.

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hayakawa16
Copy link
Member

Hi, I not sure if this is related but I just noticed that the readme.md is at the top of the VP splash page above the different repositories. It just caught my eye because at first I thought the repositories moved because they were below the fold. Not a problem, just checking.

@lmalenfant
Copy link
Member Author

Hi @hayakawa16, It is not related to this PR but I told you about the change in the other PR on the VTS repo:

I added a .github repository in the Virtual Photonics organization so we could put the VP information on the home page. I removed that information here and added the sonar cloud analytics badge to the readme.

@hayakawa16
Copy link
Member

I see. Thanks for the explanation. I had a hunch it was due to the other PR, just checked it after I saw this one.

@lmalenfant
Copy link
Member Author

@hayakawa16 please could you review this so I can merge? :)

hayakawa16
hayakawa16 approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@hayakawa16 hayakawa16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

@lmalenfant lmalenfant merged commit 0b872c0 into master Sep 30, 2023
5 checks passed
@lmalenfant lmalenfant deleted the feature/update_readme_with_sonar_cloud_information branch September 30, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayakawa16 hayakawa16 hayakawa16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmalenfant @hayakawa16